1328837476-hug opened a new pull request, #12773: URL: https://github.com/apache/seatunnel/pull/12773
### Purpose of this pull request The HTTP sink factory currently checks that `url` is present but accepts empty and whitespace-only values. This adds `Conditions.notBlank` to the existing required option, with factory tests and EN/ZH documentation updates. Related to #11007, following the [confirmed scope](https://github.com/apache/seatunnel/issues/11007#issuecomment-6168243222). ### Does this PR introduce _any_ user-facing change? Yes. Compared with current `dev`, `url = ""` and whitespace-only URLs fail during factory option validation. Nonblank values, including padded values and table-name placeholders, continue to pass unchanged. Feishu inherits the HTTP sink option rule, so its EN/ZH URL descriptions are updated too. URL parsing, placeholder substitution, HTTP requests and retries keep their existing behavior. ### How was this patch tested? The six empty/whitespace cases failed against the original factory rule and passed after the change. All 67 HTTP-base unit tests pass, including 13 factory test cases covering valid, missing, empty, whitespace-only, padded and placeholder values. Using JDK 17 and the Maven wrapper: ```bash ./mvnw -pl seatunnel-connectors-v2/connector-http/connector-http-base spotless:apply test ./mvnw -pl seatunnel-connectors-v2/connector-http/connector-http-base -am -DskipTests verify git diff --check ``` The scoped verification passed for all 12 reactor modules. Tests use the real `ConfigValidator` and do not make HTTP requests. ### Check list - [x] Added focused factory validation tests. - [x] Updated the affected EN/ZH option descriptions. - [x] No new dependencies, binary packages or connectors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
