DanielLeens commented on PR #11684: URL: https://github.com/apache/seatunnel/pull/11684#issuecomment-6190327908
Thanks @zhengxiang378928908-code, and you are right: the stale entry should not stay on record. My `changes requested` review from 2026-08-07 was written against the old head `bc75169447`. Every later round (the last one on `e3f0032171`) found no source-side blocker, and I re-checked just now that the head is still `e3f0032171` and that the apache-side `Build` check on it is `success`. I will submit an approval review on this head, the same way I did for #11686, so that my old `changes requested` is superseded. To be clear about what that does and does not cover: it is a static review of the diff plus the CI result, I did not execute the PR, and the two Low items in my last review (length semantics under `LENGTH_IN_CHAR` and save-mode DDL for national types, both pre-existing) stay non-blocking follow-ups. The remaining gate is still a committer approval from someone with write access, so please keep the ping to @davidzollo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
