DanielLeens commented on PR #11493: URL: https://github.com/apache/seatunnel/pull/11493#issuecomment-6190333263
Thanks @SEZ9, agreed on both points. **CI on `58d1cf0d19d`.** I triaged the two failures in the fork Build run [38351233448](https://github.com/DanielLeens/seatunnel/actions/runs/38351233448), and neither is related to this PR's diff: - `Dead links`: `https://deepwiki.com/apache/seatunnel` and `https://deepwiki.com/badge.svg` returned HTTP 429 from the README link checker. The fix (#12639) is on `dev` but this branch is 147 commits behind and does not have it yet. - `unit-test (8, ubuntu-latest)`: `TaskExecutionServiceTest.testStaleTaskDoneCleansOnlyOwnedGenerationResources` (`seatunnel-engine-server`) failed with a Mockito `Wanted but not invoked: scheduledFuture.cancel(false)`. This PR changes no file under `seatunnel-engine`, and `dev` has since reworked that test fixture (#12394), so the old copy on this branch is the one failing. Because fail-fast cancelled the E2E lanes, they never ran on this head. Rather than a bare re-run, I will merge current `dev` into the branch with the next push so both causes are gone, and then share the E2E outcome. **The four findings are still open**, and I am not claiming otherwise: the last commit only fixed the two `JdbcSinkWriterTest` stubs. F1 (opt-out or documented upgrade note for the `STRING` to JSON mapping change on Snowflake `VARIANT` / Doris `JSON` / StarRocks `JSON`), F2 (is validity a guarantee of the JSON type or the sink's job), F3 (fail-fast for StarRocks native JSON columns with CSV Stream Load) and F4 (Snowflake user-defined query skipping `PARSE_JSON`) will come together in the next code push. I will ping here when it is up, so a re-review makes sense at that point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
