DanielLeens commented on PR #11077:
URL: https://github.com/apache/seatunnel/pull/11077#issuecomment-6190331112
Thanks @hesam-oxe for the follow-up. A quick status so we are looking at the
same facts (head `8b383c04eeed65c41a14ba756100a33f430124eb`, which is still the
head I reviewed on 2026-10-13; I do not see a newer commit on the branch):
- CI: the apache-side `Build` check on this head is still `action_required`
("Workflow run detection failed") and your fork has no workflow run for this
commit, so there is no failing check to flag yet; CI simply never started. To
fix that, please enable GitHub Actions workflows in your fork (Actions tab,
enable button if shown) and then push an empty commit (`git commit
--allow-empty -m "Trigger CI"`) or start the `Build` workflow manually on this
branch. Reference check run:
https://github.com/apache/seatunnel/runs/114987916217 . The branch is also now
`diverged` from `dev` (ahead 38, behind 24), so please sync the latest `dev` in
the same push and keep every entry of both `incompatible-changes.md` files when
resolving conflicts.
- Code side: my three open items from the last review are unchanged and
still need a commit: (1) the incompatible-changes entries (en and zh) and the
release note promise a startup `IllegalStateException` that cannot occur for
the file sink, because the row layout is already folded into the file sink's
destination identifier, so please describe the real behavior; (2) tests that
pin the new identifier components (hdfsNameKey, tmp_path, file_name_expression,
one extraOptions entry) and the metadata-only-schema sharing case; (3) the CI
run itself. The SEZ9 questions about the collision test and the legacy-restore
test are best answered together with (2) in the same commit.
Once the new head is pushed and CI has started, I will re-check the full
diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
