nzw921rx commented on PR #12804:
URL: https://github.com/apache/seatunnel/pull/12804#issuecomment-6206225217
The `ALL_MATCH` follow-up is fixed as well on `488b17b`:
* `ChainedMapTransform#getProducedCatalogTables()` now exposes the extra
tables of every rule in the
chain (deduplicated), so the `DataValidator` error table reaches the sink
when duplicate
`table_path` entries are chained.
* `ChainedMapTransform#map()` returns as soon as a rule routes the row to
one of its extra tables,
so the error row is not fed into the next validator.
*
`DataValidatorTransformFactoryTest#testAllMatchRouteToTableStopsTheChainAndExposesTheErrorTable`
covers routing by the first rule, routing by the second rule and the
pass-through case, and asserts
that the produced tables are `db.fake` + `db.error_data`. Removing the
stop logic makes the test
fail (`ArrayIndexOutOfBoundsException` while generating a second error
row).
The change is a no-op for the other transforms (none of them declares an
extra table) and for
`DataValidator` without `ROUTE_TO_TABLE`. No E2E was added for this edge
case, to avoid growing the
already long transform E2E jobs; `seatunnel-transforms-v2` UT is 1370/1370
green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
