SEZ9 commented on PR #12595: URL: https://github.com/apache/seatunnel/pull/12595#issuecomment-6206393982
@SEPURI-SAI-KRISHNA thanks for closing the loop on the CI question — that was the one open item from my side, and it is answered. To confirm what I take from your update: - `Build` on head `db7c965c1c` is passing (run `38523018557`), and that head is only a `dev` merge over `364514f12c` with the PR's own patch unchanged. - The two reds on the first attempt (`DatabendCDCSinkIT.testDatabendSinkCDC` in `connector-databend-e2e`, and `GooglePubSubIT.testGooglePubSubSourceAcknowledgesAfterCheckpoint` in `connector-google-pubsub-e2e`) both passed on the failed-jobs rerun with no code change. Since this PR only touches `seatunnel-engine-server` and `seatunnel-engine-e2e`, I agree neither module is reachable from the diff, so I treat those as unrelated flakes rather than something this PR needs to act on. - The earlier `CassandraIT` failures are gone now that `07d6f2235a` is in the branch via the `dev` sync. - The corrected javadoc wording for `credentialMatches` is in the pushed history at `b3f26aeb9`, which is what I asked for last round. So from my perspective: the javadoc ask is satisfied, `dev` is synced, CI is green, and I have nothing further outstanding on the previously raised point. As you note, the PR still shows `review-required`, so the remaining gate is a committer approval; nothing more is needed from you for that. <!-- streview-comment:1778 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
