fatmanverse commented on PR #12800: URL: https://github.com/apache/seatunnel/pull/12800#issuecomment-6207000267
Thanks @ryanmeowy and @DanielLeens for the reviews. Added the reflection-based completeness test in 59b7d7c: `JdbcOptionRuleCompletenessTest` collects every public static `Option` of `JdbcSourceOptions` and `JdbcSinkOptions` (including the inherited `JdbcCommonOptions`) and checks that the factory rule accepts all of them through `validateUnknownKeys`. The exclusion list has a single entry, `schema` on the source, which only the sink path and the catalog factories read. The test found three more keys missing on the source: `access_key_id`, `secret_access_key` and `region`. The source reaches the DSQL connection provider through the shared `JdbcConnectionConfig` too, so they are now declared there as well. The PR description is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
