DanielLeens commented on issue #12815:
URL: https://github.com/apache/seatunnel/issues/12815#issuecomment-6217835800

   Classification: A / Connector-V2 file-source static-validation option 
coverage.
   
   The inconsistency is confirmed by the current code shape: the runtime 
readers consume options such as csv_use_header_line, binary_chunk_size and 
read_partitions, while the LocalFile source OptionRule does not expose all of 
them to static validation. A working runtime configuration must not be rejected 
by --check or --dry-run.
   
   Please keep the correction limited to bringing each file source factory's 
OptionRule into parity with the options it actually supports. Add validation 
tests for LocalFile with CSV, binary and partition options, plus a command-path 
regression for --check and --dry-run. Do not loosen unknown-key validation 
globally, and preserve each option's format-specific restrictions.
   
   Please link a focused PR once those cases are covered.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to