DanielLeens commented on issue #12821:
URL: https://github.com/apache/seatunnel/issues/12821#issuecomment-6217836549

   Classification: A / Connector-V2 ClickHouse sink nullable-key batch 
reduction.
   
   The source inspection confirms that ReduceBufferedBatchStatementExecutor 
uses the extracted primary-key SeaTunnelRow as a LinkedHashMap key. Since 
NULL-valued keys compare equal, the reported reduction can collapse several 
distinct nullable-key rows before any SQL is executed.
   
   Before a fix, please add a real ClickHouse regression using a MergeTree 
table with allow_nullable_key = 1 and multiple rows whose configured key is 
NULL. Cover both the normal insert path and the delete/update path, and include 
a composite key with one NULL component. The expected policy is that an 
incomplete key must not participate in last-write-wins reduction; complete keys 
should keep existing behaviour.
   
   Please keep the patch in the ClickHouse executor rather than copying JDBC 
code blindly, and link the focused PR here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to