Rishavbhattarai commented on PR #12831: URL: https://github.com/apache/seatunnel/pull/12831#issuecomment-6224830290
Thanks @DanielLeens for the review, and @davidzollo for the CI link. Actions is now enabled on my fork, and CI is green: https://github.com/Rishavbhattarai/seatunnel/actions/runs/38951749264 I fixed all four issues in 7dc5978: 1. `buildWithConfig` now calls `validateCredentialScheme()` after it sets the URL and the `Authorization` header, so an `http://` base_url logs the cleartext warning. 2. I added a Javadoc to `buildWithConfig`. It covers the validations, the retry default (3, only when `retry` is not set) and the warning. 3. The E2E mock returns page 2 only when `starting_after` matches the cursor from page 1. Any other request gets a 400, so the job fails if the cursor is not sent back. The Assert sink also checks that `created_at` is a non-null bigint. 4. The interrupt test now interrupts a worker thread while it sleeps in the backoff, then checks for the `Interrupted while backing off` message and the restored interrupt flag. To check the test, I removed the interrupt handling from the reader, and the test failed. The 13 unit tests pass locally, and `IntercomIT` passed in CI on Java 11 and 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
