SEZ9 commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-6228437261
Thanks for the reply, @nzw921rx — no rush, and appreciated. To keep the re-review straightforward, I'll leave the head at `7948e2640` untouched until you've had a look, so whatever you review is the exact commit that has already been gone over for F1–F6. The only thing your 2026-09-10 review asked for was to not add the growth scenarios to the refactored benchmark docs; that was done in `9a6077c58`, and the current head no longer touches `docs/en|zh/engines/zeta/benchmark.md`. The remaining diff is limited to `seatunnel-benchmarks` plus `JobHistoryService` and its test. Two things I'd like your direction on when you get to it: 1. Rebase timing — the branch is now well behind `dev`. I'm happy to sync as soon as you indicate the review direction (or before, if you'd prefer to review on a current base). Either way I'll post the new head here so the F1–F6 verification can be re-confirmed on it rather than carried over. 2. Scope — if you'd rather the production `JobHistoryService` change (F2/F5/F6) be split out from the benchmark work (F1/F3/F4) so each can land independently, say so and I'll open the split. If neither is needed and the docs concern is resolved from your side, clearing the `CHANGES_REQUESTED` on this head is all that's left. Thanks again. <!-- streview-comment:1806 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
