WXPNG commented on PR #12755: URL: https://github.com/apache/seatunnel/pull/12755#issuecomment-6229214219
Thanks @SEZ9 for re-checking! To confirm on head 19a3592c, all five points are addressed: 1. **F1/F3 (empty candidate list + all-permanent blacklist)**: `logRetryState()` now distinguishes three states — WARN "no candidate master addresses" for an empty list, WARN "all candidate master addresses are permanently blacklisted" for the all-permanent case, and INFO "temporarily blacklisted, will keep retrying" only for the genuine temporary case. So we no longer log "temporarily blacklisted" when nothing temporary was found. 2. **F4 (Hazelcast's blacklist log pair)**: `blacklist()`/`unblacklist()` are overridden to log at FINE for a lite member's temporary entries, so the per-cycle "added/removed" INFO pair is gone. 3. **F5 (docs)**: added a note to both `docs/en` and `docs/zh` separated-cluster-deployment.md. 4. **F6 (test cleanup)**: both started-before-master tests now `interrupt()`+`join()` the worker thread and call `HazelcastInstanceFactory.shutdownAll()` in `finally`. 5. **F7 (description/Javadoc)**: PR description updated and the test Javadoc no longer uses the stale "Scenario N" numbering. Would appreciate another look when you have a moment. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
