hutiefang76 commented on PR #12578:
URL: https://github.com/apache/seatunnel/pull/12578#issuecomment-6230916198

   The write is already guarded at ef53a70c6: `setField` assigns the field, 
then only writes `size = 0` inside `if (size != 0)`. The method also has 
Javadoc saying that it clears the cached estimate and that direct `getFields()` 
/ nested-object mutations bypass invalidation. Both are in [SeaTunnelRow.java, 
lines 
52–60](https://github.com/apache/seatunnel/blob/ef53a70c6f72f5f6ae7c31fcc57b541eb3c849f3/seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java#L52-L60).
   
   The cross-overload and direct/nested-mutation tests discussed above are 
present in the same head. No further source change is needed for those points.
   
   I also checked the failed Notify job: it received a GitHub API 500 while 
creating the Build check, before any tests ran. The fork’s Actions setting is 
enabled and Build is active; I’m following up on the missing run separately.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to