SEZ9 commented on issue #10753:
URL: https://github.com/apache/seatunnel/issues/10753#issuecomment-6245242423
Thanks @Rishavbhattarai for opening #12844 for Typeform. Tracker status is
now:
- **Typeform Source**: design review on #12822, implementation PR #12844
open. Per the latest tracker note the PR is currently marked as conflicting
with `dev`, so please rebase and resolve that before it goes to review. The row
stays in progress until the check and review results are resolved.
- **Intercom Source**: design review on #12823, implementation PR #12831
open and still awaiting review. Row stays in progress.
Neither row is recorded as a completed connector yet.
One clarification on scope so the tracker stays accurate: the Typeform row
is scoped to form responses from `GET /forms/{form_id}/responses` with a
required `form_id`, as you proposed; the contacts-only scope belongs to
Intercom on #12823. Please keep each connector in its own issue and PR, with no
cross-connector dependency or shared client change unless that smaller change
is proposed and reviewed independently.
Remaining asks:
1. Rebase #12844 onto current `dev` and confirm here once the conflict is
cleared.
2. Confirm that #12844 matches the design settled on #12822
(bearer-token-only auth, `before` cursor paging, bounded backoff on 429/5xx,
offline E2E with a mock server) and that any further technical discussion stays
on the PR and feature issue.
3. Post here again only when either PR merges, so the rows can be marked
Done.
<!-- streview-comment:1841 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]