SEZ9 commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-6245236987
Thanks for keeping the branch current. As I understand it, head `c3b70de226d0` differs from `e72541e9fe` only through the `dev` merges (`cd05aece52`, `df38a415ec`, `c3b70de226`), with no change to the PR's own lines, so my earlier points still stand until I can verify them against the diff. Could you confirm or point me to the relevant changes for each? - **Redirects**: is `followRedirects(false)` / `followSslRedirects(false)` set on the new client so configured report headers are not forwarded to another host? - **`close()` robustness**: does `close()` flush only after the scheduler has actually terminated and the thread is not interrupted, catch and log all flush failures (not just `HazelcastInstanceNotActiveException`/`IOException`), and cancel the dispatcher, evict the pool and restore the interrupt flag in `finally`? - **Kotlin graph**: is the Kotlin stdlib pinned to a single version (e.g. via a BOM), with the known-dependencies list and LICENSE inventory carrying only that version? - **E2E wait strategy**: the `received new worker register` wait strategy is still set in `executeExtraCommands`, after the container lifecycle is configured, so it does not reliably gate server readiness. Could you move it onto the container lifecycle? - **Retry test**: please use the timeout variant of `takeRequest()`, close the request `Buffer`s, and either trigger the flush explicitly or use a short interval rather than relying on the 1-day scheduler firing immediately. - **Content-Type**: okhttp3 `RequestBody.create(String, MediaType)` appends `; charset=utf-8` when the configured media type has no charset. Could you confirm, ideally with a test assertion, that the reported header stays byte-identical for existing collectors? Happy to re-review once these are in or confirmed. <!-- streview-comment:1840 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
