DanielLeens commented on PR #12208: URL: https://github.com/apache/seatunnel/pull/12208#issuecomment-6258267561
Thanks @88fantasy for the kind words, and for the patience through all the rounds. One practical heads-up: GitHub now reports this PR as having merge conflicts with `dev` (mergeable state: dirty; the head `d3209a898` is currently behind `dev` by 48 commits). The Approve you asked for will not be enough to land it, because the PR cannot enter the merge queue while it conflicts. Please sync the latest `dev` and resolve the conflicts. From my previous pass, the likely hot spots are the dependency and license files touched by the new `seatunnel-lineage` module, as in your earlier sync. A re-sync should not change the author code I reviewed, but it will need a fresh CI run on the new head. My assessment of the source itself is unchanged from my last review: no source-side blocker. The committer Approve remains outside what I can provide as a read-only reviewer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
