zhengxiang378928908-code commented on PR #12787:
URL: https://github.com/apache/seatunnel/pull/12787#issuecomment-6258810412

   Thanks, @DanielLeens. Pushed ab885d5cd:
   
   - **Issue 1**: added "Depends on #12862" at the top of the description. 
#12862 should land first.
   - **Issue 2**: since this PR lands last, the Spark note is here, in 
`incompatible-changes.md` (en/zh): top-level and `ROW`-nested `LARGEINT` is 
carried as text on Spark and restored to `DECIMAL(39, 0)`; `LARGEINT` inside 
`ARRAY`/`MAP` now fails at job start with `SPARK-TRANSLATION-01` (it worked 
before as `DECIMAL(20, 0)`). Migration: leave those columns out with 
`doris.read.field`, or run on Zeta/Flink. An SQL transform can't help there, 
because Spark fails while building the source schema.
   - **Issue 3**: `assertNestedLargeintRejected` now checks only the error 
code, the column path and the table, not the message wording. Each 
`spark/*.conf` header now says it differs from its base job only in 
`doris.read.field` and must be kept in sync (I diffed all eight against their 
base jobs to confirm).
   
   The previous combined run 
([39139304609](https://github.com/zhengxiang378928908-code/seatunnel/actions/runs/39139304609))
 finished all green after re-running the timed-out job. A new combined run with 
both new heads is in progress 
([39193334501](https://github.com/zhengxiang378928908-code/seatunnel/actions/runs/39193334501));
 I'll post the result.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to