fatmanverse opened a new pull request, #12892:
URL: https://github.com/apache/seatunnel/pull/12892
Follow-up to #12803 (#12799). Test only, no production code change.
### Purpose of this pull request
The triage of #12799 asked for regression coverage of "multiple null-key
rows, mixed null/non-null keys, and the existing non-null deduplication
behavior". #12803 covers these for a single-column key. A key derived from a
unique key can also span several columns, where only one component is NULL.
This adds
`BufferReducedBatchStatementExecutorTest#testCompositeKeyWithNullComponentIsNotReduced`:
with a two-column key, two rows whose key has a NULL component both reach the
upsert executor, while two rows with the same fully non-null key are still
reduced to the last one.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
`./mvnw -pl seatunnel-connectors-v2/connector-jdbc test` on JDK 17: the new
test and the rest of the module pass, except
`JdbcOptionRuleCompletenessTest#testSinkRuleDeclaresAllSinkOptions`, which
already fails on `dev` since #12792 and is fixed by #12875 (#12874).
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [x] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs (not needed)
* [x] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR. (not needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
