nzw921rx opened a new pull request, #12898:
URL: https://github.com/apache/seatunnel/pull/12898
### Purpose of this pull request
Fix the CLI UX issues reported while testing the Kubernetes Application Mode
MVP:
- `-h`/`--help` printed usage but then failed with `status/cancel require
--id` and exited non-zero.
- A successful cancel followed by `status` printed `Fatal Error / submit a
bug report` because `UNKNOWN`/`CANCELED` were treated as failures.
- The commands doc promised `CANCELED` after cancel, while the
implementation and FAQ return `UNKNOWN` after the owner Job is deleted.
This PR short-circuits help before command validation, treats only `FAILED`
as a failure, and aligns the documentation with the actual Kubernetes lifecycle.
### Does this PR introduce _any_ user-facing change?
Yes:
- `-h`/`--help` now prints usage and exits 0 for both `seatunnel.sh` and
`seatunnel-application.sh`.
- Plain `status` and `status --wait` now report `CANCELED`/`UNKNOWN`
normally; only `FAILED` makes `--wait` exit non-zero.
- `cancel` still deletes the owner Job, so a later `status` remains
`UNKNOWN`; the docs now say so instead of promising `CANCELED`.
### How was this patch tested?
- `./mvnw spotless:apply`
- `./mvnw -pl seatunnel-core/seatunnel-starter
-Dtest=ApplicationExecuteCommandTest -DfailIfNoTests=false test` -> 14/14 passed
- Manual CLI checks against the compiled classes:
- `SeaTunnelApplication --help` -> usage, exit 0
- `SeaTunnelApplication status -t kubernetes --help` -> usage, exit 0
- `SeaTunnelClient --help` (`seatunnel.sh`) -> usage, exit 0
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
