SEZ9 commented on PR #12784: URL: https://github.com/apache/seatunnel/pull/12784#issuecomment-6282526343
Both items addressed, thanks @DanielLeens. **Issue 1 (the spent-budget exception).** You were right that the README described when a loop is claimed but not that a spent restore budget is reported from the first restore. Both READMEs now say so and name the configuration that produces it (`job.retry.times = 1`), and the `CRASH_LOOP_RESTORES` comment now records that the exhausted finding is the exception to "only fires from the second restore" — the sentence was still true of the crash-loop finding itself, which is exactly why it read as if it covered both. **Issue 2 (the redundant guard).** Kept it, with a comment. You are right that it is subsumed by the gate below, and the reason a reader pauses on it is the thing worth writing down: without the comment it looks as if `restoreCount == 0` were handled specially, when it is just an explicit early exit. 335 tests pass locally and `ruff check` is clean with the pinned `ruff==0.16.7`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
