SEZ9 commented on PR #12794: URL: https://github.com/apache/seatunnel/pull/12794#issuecomment-6282526872
Addressed, thanks @DanielLeens — and good catch on the fallback. I had written that `generatedAt` comes from the serving member's clock but stopped short of the consequence: `getMonitorService()` falls back to a non-master member when the master lookup returns null, so `generatedAt` and `triggerTimestamp` can come from different nodes, and the subtraction the docs recommend is only as good as the clock sync between them. Both language versions now say that member clocks are assumed to be NTP-synchronised, in the `generatedAt` row where someone reading the recommended calculation will see it. On CI: the earlier `Build` failure on this head was `doris-connector-it`, and it was unrelated to this change — testcontainers could not start `apache/doris:doris-all-in-one-2.1.0` (`Timed out waiting for container port to open`, with the Doris FE log reporting `available backend num is 0`, so the BE never came up in the container). The four `unit-test` jobs, `engine-v2-it`, `Code style` and `License header` all passed on that same run, and the new test ran green there: `Tests run: 3, Failures: 0, Errors: 0 - in CheckpointMonitorRestServiceTest`. I re-ran that single job rather than the whole matrix, and this push will produce a fresh run in any case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
