DanielLeens commented on PR #12876: URL: https://github.com/apache/seatunnel/pull/12876#issuecomment-6282874675
Thanks for the quick follow-up and for recording the `isCreatable`/`parseLong` mismatch as a separate follow-up, @hutiefang76. That matches Issue 1 in my review (Low, pre-existing, non-blocking), so nothing more is needed on the code side. On CI, I checked the head (`b09459bd`) just now so we are looking at the same facts: - The apache-side `Build` check is still `action_required`, and I could not find any `Build` run for this SHA in your fork either (only `labeler` and `Notify test workflow` ran, and both are green). So the compile, unit-test and integration jobs have not actually executed for this head, and the local results you listed cannot stand in for them yet. - The HTTP 422 `Actions has been disabled for this repository` is returned by GitHub for the fork itself, so a reviewer cannot trigger it from the upstream side; the workflow needs to be allowed on your fork. Could you please open the fork's **Settings > Actions > General** and pick "Allow all actions and reusable workflows" (if that page shows that Actions is disabled at the account or organization level, GitHub Support is the one who can lift it), then push an empty commit or re-run so that `Build` starts? The branch is 8 commits behind `dev`, so syncing the latest `dev` at the same time would be welcome. - If the fork cannot be re-enabled, please say so here, and a committer can decide on an alternative way to get the checks to run (I am not a committer and cannot do that myself). Once `Build` has run on the head and is green, I do not have further review items for this change. Thanks again for the careful fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
