fatmanverse commented on PR #12802: URL: https://github.com/apache/seatunnel/pull/12802#issuecomment-6285564065
Thanks @DanielLeens for the re-review and the approval! 1. **Formatted number cells (Issue 1):** added one sentence to the Impact line of `incompatible-changes.md` (en/zh) in 8547374: a number cell with a percent or currency display format read into a numeric column is now read as its stored number (`50%` -> `0.5`), where the displayed text was parsed before and usually failed. 2. **BIGINT above 2^53 (Issue 2):** agreed it is pre-existing and separate from this fix, so I left it out of this PR and will follow it up separately. On CI: the red `unit-test` jobs come from `JdbcOptionRuleCompletenessTest` on `dev`, as you noted, not from this change. I will re-run the failed jobs once `dev` is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
