DanielLeens commented on PR #10252:
URL: https://github.com/apache/seatunnel/pull/10252#issuecomment-6287317389
Pushed two commits on top of your branch, @BrandaoFelipe: a merge of the
current `dev` (conflicts in `connector-jdbc/pom.xml` and `JdbcPostgresIT.java`
were additive entries from `dev` next to yours and are kept on both sides), and
the build-side fixes from the reviews:
- `junit-jupiter-api` in `connector-jdbc/pom.xml` now has
`<scope>test</scope>`, so it no longer leaks into the connector's
compile/runtime classpath.
- The `junit-bom` import this PR added to `connector-jdbc`'s
`dependencyManagement` is removed: the root POM already imports the same BOM,
and a nested BOM import inside `connector-jdbc` broke the `connector-cdc-db2`
module, which imports `connector-jdbc:pom` from the reactor ("Non-resolvable
import POM: connector-jdbc:pom:3.0.1-SNAPSHOT"). That is very likely the real
cause of the red Build on the earlier head; with the import removed the reactor
resolves again locally.
The non-blocking asks (static `seatunnel.engine.port` system property in
`AbstractPostgresContainerTest`, cleaning up `test_catalog_table` and closing
the catalog on assertion failure, the inert `@Testcontainers` annotation, the
borrowed logger) are still yours. Your fork did not create a Build run for this
push; if none appears, please start one from the Actions tab ("Run workflow" on
Build). Verification run:
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr10252-verify-3c2b7afaa5e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
