DanielLeens commented on PR #12684: URL: https://github.com/apache/seatunnel/pull/12684#issuecomment-6289474974
Correction to my comment from 2026-10-19: that note said my technical conclusion had changed to approve once Build went green. That was wrong. CI was not the only blocker on this head. My last review of the unchanged head `c49b97a9` still has one open source-side blocker, Issue 1: with `max_retries` unset (it has no default, so the budget is 0) and `node_urls[0]` down, `tryInit()` skips the dead node but the first `flush()` still routes unknown devices to index 0, `sessionFor(0)` throws, and `networkFailures[0] >= networkBudget` fails the flush (`IoTDBSinkClient.java:99-126`, `:394-403`, `:439-448`). The existing test `shouldStartWhenTheFirstNodeIsDown` only passes because it sets `maxRetries = 1`. Build is green on this head, which is good, but the head has not changed, so the blocker stands. Please see Issue 1 in my earlier review for the suggested fix (use the first reachable node learned in `tryInit()` as the default index) and a `max_retries = 0` test. Happy to re-review as soon as you push. Sorry for the confusing note. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
