DanielLeens commented on PR #11844: URL: https://github.com/apache/seatunnel/pull/11844#issuecomment-6284832414
Pushed `c2dc06560d4` on top of your branch (merge of current `dev` plus one commit), @zhang-arvin, so the PR is no longer conflicting and the open items from my last round are closed: - Merge conflict in `docs/en|zh/connectors/source/MySQL-CDC.md`: resolved by keeping the new `stop.mode = latest` wording from `dev` and appending the `snapshot-only` note after it. - Issue 1: `MysqlCDCSnapshotOnlyIT.SINK_TABLE` is now `mysql_cdc_e2e_sink_table`, the table the conf writes to and the DDL creates. - Issue 2: `clearTable` now throws instead of logging a warning, so a setup problem fails fast. - Issue 3: reworded the `getCheckpointCapturedTables` Javadoc so it no longer promises behavior for dropped tables. - Nit: replaced the fully qualified `StartupMode` in `MySqlIncrementalSourceStartupConfigTest` with an import. Only `spotless:apply` was run locally; the fork CI run for the new head is the verification. Please take a look and let me know if you would rather have any of this done differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
