SEZ9 commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-6306244098
@Rangsh — re-confirming F1–F6 against `b137173f7`, taking your diff summary as given (no new push, so nothing new to read): - **F4 — closed as intentional.** Since the growth-scenario notes were added in `909f87840` and removed in `9a6077c58` after the benchmark docs refactor, I won't ask for a note in `docs/en|zh/engines/zeta/benchmark.md`. The Javadoc in `IMapJobStorageBenchmark.java` stays the source of truth. - **F2 / F5 / F6 — still open, unchanged.** With `JobHistoryService.java` and `JobHistoryServiceFinishedMetricsTest.java` byte-identical to `ca82f95d3b` (and `909f878402`, `c0d59da54`, `7948e2640`), all three findings stand exactly as written. They are all LOW. Ask: either push a follow-up that (F2) makes the merge atomic or at least documents the per-JobMaster-lock assumption as an explicit precondition, (F5) separates historical rationale from the contract and fixes the "in memory" wording, and (F6) asserts the observable contract and adds the null-metrics / TTL-preserving cases — or tell me explicitly which of the three you want deferred to a separate PR and I'll record that. - **F1 / F3 — need your answer.** Your comment doesn't cover these. Both are in `IMapJobGrowthBenchmarkWorkload.java`, which is in the diff you listed, so please state whether `b137173f7` changed the trial-tear-down durability sample (F1) or the last-key-only check (F3), or whether they are unchanged. If unchanged, F1 (MEDIUM) is the one item I still want resolved before merge; running the single `loadAll` over the whole final batch (F3) would at least recover meaningful coverage at the same replay cost. Once I have the F1/F3 status, I'll mark the re-confirmation complete. <!-- streview-comment:1904 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
