DanielLeens commented on PR #12015: URL: https://github.com/apache/seatunnel/pull/12015#issuecomment-6310063380
@SEZ9 thanks for the follow-up. Your three open items (F6, F7, F8) are answered against this exact head, `82fc5e61a`, in my approving review posted at 00:41Z (the head has not changed since). Condensed, so you can verify directly: - **F6 (invalid regex):** every pattern in the map is compiled up front in `JdbcSinkFactory.toCompiledPatternMap` (`JdbcSinkFactory.java:345`) via `compilePattern` (`:362`), which raises `INVALID_MULTI_TABLE_CONFIG` (the JDBC-12 family) with the offending pattern. So a bad regex fails when the sink is created, not lazily when a particular table is matched. The `optionRule` extension (`JdbcMultiTableConfigConditionExtension`) only validates the shape. Tests are `JdbcSinkFactoryTest#testResolveMultiTablePrimaryKeysInvalidRegexFails` and `#testCompilePatternInvalidFails`. - **F7 (engine-level coverage):** `JdbcMysqlMultipleTablesIT#testMysqlJdbcMultipleTableE2e` now runs `jdbc_mysql_source_and_sink_with_multi_table_config.conf` (in `connector-jdbc-e2e-part-1`), so the option is exercised through the engine, not only the factory. - **F8 (key naming):** the final user-facing key is `multi_table_config`; there is no `multi-table_config` left in the PR diff (code option and both docs use the snake_case spelling). CI for this head: the apache-side `Build` check is `pass`, so I have no remaining non-CI blocker. A write-capable maintainer still needs to give the final approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
