zhengxiang378928908-code commented on PR #12937: URL: https://github.com/apache/seatunnel/pull/12937#issuecomment-6330564608
Thanks for the second review. I addressed the three suggestions in e89377a4d: 1. **Downgrade**: `incompatible-changes.md` (EN/ZH) now says that a job stopped while a split checkpoint is being committed must be restored with this version or later, because an older version skips the whole checkpoint once it finds any of its snapshots. 2. **Results without records**: a group that has no records no longer ends a commit group. The following rounds join it, so a leading empty flush (for example right after a schema change) doesn't produce a group that commits no snapshot. Nothing is dropped, and a checkpoint whose results are all empty is planned as before. `resultWithoutRecordsDoesNotOpenAGroup` covers this. Without the change it gets groups `1/4, 2/4, 3/4`, with no snapshot for group 0. 3. **Latency**: the `flush_row_size` docs now say that the snapshots of a checkpoint are committed one after another before the checkpoint completes, so a very small value also makes checkpoints take longer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
