zhangshenghang commented on PR #12679: URL: https://github.com/apache/seatunnel/pull/12679#issuecomment-6332105736
The four blocking issues are addressed in 27297d2f8: 1. **OneSignal example** (en+zh): `pageing` is dropped and the example shows a single request; a note states that `pageing` advances the page index by exactly 1 per request and cannot express a stride, and that OneSignal's `offset` is a record offset (so combining them reads overlapping windows). 2. **InfluxDB `where` caution** (zh fix + en updated too, as suggested): the two modes are described separately — single-table `sql` mode: `where` has no effect and the split parser is case-sensitive; `tables_configs` mode: `where` fails at build time with `OptionValidationException` and the split parser is case-insensitive. 3. **Greenplum sink type table** (en+zh): flipped to the sink direction derived from `PostgresTypeConverter.reconvert` — `TIMESTAMP` and `TIMESTAMPTZ` are separate rows (`TIMESTAMP(p)` / `TIMESTAMPTZ(p)`), `STRING` shows `TEXT`/`VARCHAR(n)`, `TINYINT` joins `SMALLINT`, and the table note explains that `DECIMAL` lands as `NUMERIC(p, s)` while `MONEY` only occurs on round-trip of an already-`money` source column. 4. **partition bound types**: `partition_lower_bound`/`partition_upper_bound` changed to `String` on the Mysql, PostgreSQL, OceanBase, Redshift and SqlServer pages in both languages, including the `#### partition_lower_bound [String]` prose headings, matching `JdbcSourceOptions`. The Low items (5-7) and the description refresh are still open, left for a follow-up round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
