SEZ9 commented on issue #12939: URL: https://github.com/apache/seatunnel/issues/12939#issuecomment-6331715677
Thanks for the detailed report, and for volunteering to fix it. The analysis looks consistent: ServerCommandArgs documents master_and_worker as a supported value for -r/--role and EngineConfig defaults to MASTER_AND_WORKER, so the missing branch in ServerExecuteCommand.execute() is an inconsistency between the CLI help and the parser. Your proposed fix (adding an explicit MASTER_AND_WORKER branch) looks reasonable. When you open the PR, it would be great to include a unit test covering the role parsing (master, worker, master_and_worker, and an invalid value). Could you also mention which SeaTunnel version you reproduced this on, so we can check whether it affects the latest release branch as well? <!-- streview-comment:1942 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
