Nikk8091 commented on PR #12944: URL: https://github.com/apache/seatunnel/pull/12944#issuecomment-6339122304
Thanks for the detailed review. Pushed `ca971f983e50bfa0823dd20e883fdfa379d5b081`: I extended the existing `MetalakeIT.testDataSource` scenario and its datasource-enabled fixture; no new integration suite was added. The JDBC query now returns a constant string under the literal column name `^metadata_.*$`. `FieldMapper` consumes that exact quoted key and produces `metadata_literal_value`; the Assert sink checks both non-nullness and the exact value `metadata-literal-key`. All six original columns, existing field checks, row-count bounds and the Java zero-exit-code assertion remain intact. The metadata-enabled setup and `metadata_datasource_id = "test_catalog"` are unchanged, so this scenario traverses the engine gate and the later legacy Metalake conversion. The existing 14 metadata unit tests passed again on the combined tree. A separate local fixture sanity check reproduced `BadPath` without the quoting helper and verified full configuration preservation with it. This is not an engine-run claim. As requested, I did not run the container integration test locally. The 68-module JDBC E2E prerequisite reactor also passed formatting, compilation (including `MetalakeIT`), packaging and `verify` with tests explicitly skipped: `mvn -o -B -ntp -pl seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-7 -am spotless:apply verify -DskipTests -DskipIT=true -Dskip.ui=true`. These remain combined-tree results with #12443 head `3d6c855f`, not a standalone or GitHub CI pass for this dependency-blocked branch. The PR remains a draft. #12443 is still open, and I have not copied its helper into this PR or included its changes in the diff. After that prerequisite lands, this branch needs an updated base and a real final-head Build. The fork Actions activation/dispatch gate is still unresolved; no CI success is claimed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
