zhangshenghang commented on PR #12409:
URL: https://github.com/apache/seatunnel/pull/12409#issuecomment-6339661820
Both blocking issues are addressed in d2da20ffd:
1. **GraphQL streaming example** (en+zh): `variables = {}` is now explicit,
so the writer starts from a Map instead of casting the `"{}"` string fallback —
the example no longer fails with a `ClassCastException` before the first
request.
2. **SQL Server CDC heartbeat** (en+zh): the slot claim is removed. The
section now says the action refreshes SQL Server CDC's LSN tracking through the
source database connection, that it does not pin a consumer retention window
and does not replace correctly configured CDC retention and outage/lag
monitoring (linked to Microsoft's CDC cleanup documentation), and that the
heartbeat table belongs in the **source** database with the action query being
an INSERT to execute against it.
The non-blocking items (3: InfluxDB recovery wording, 4: Prometheus replica
example, 5: GraphQL Fibonacci backoff) remain open for a follow-up round.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
