DanielLeens commented on PR #11634:
URL: https://github.com/apache/seatunnel/pull/11634#issuecomment-6341266055
Thanks @waterWang. A quick correction to the CI note in my last review: I
said all checks on this head were still queued, but the fork has since run the
`Build` workflow for head `4e85efec` and it finished red. I looked at the
failing jobs and neither failure points at this PR's diff:
- `unit-test` (all four matrix entries):
`LLMBooleanOutputTest.readsLegacyFactoryWrapperWithValidationDisabled:248 >>
InvalidClass` in `seatunnel-transforms-v2` (1453 tests, 1 error). This PR does
not touch that module; it is base drift on `dev`, and the fix was just merged
in #12938 ("Restore archived LLM wrapper deserialization").
- `jdbc-connectors-it-part-7` (JDK 11): `MetalakeIT.startUp:158` timed out
waiting for the Trino/Presto containers (ConditionTimeout). This looks like an
environmental container-startup timeout, not related to the JSON format change.
This is an inference from the logs.
Next step for CI: this branch is now 12 commits behind `dev`, so please sync
the latest `dev` into the branch so the unit-test job picks up #12938, then
re-run the failed jobs. That does not change the open review items from my last
review (nested-row positional defaults, changelog formats, parse-error masking,
docs); those are still the real blockers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
