zhengxiang378928908-code commented on PR #12945: URL: https://github.com/apache/seatunnel/pull/12945#issuecomment-6342966300
Thanks for the review, @DanielLeens. Updated in 80390e4ad: 1. **IT**: `DorisIT#testTimestampTzZoneWarning` runs a FakeSource `TIMESTAMP_TZ` value into two auto-created tables, one without `sink.datetime-timezone` and one with `Asia/Shanghai` as the control. It checks that only the first table gets the warning, reads the zone from that warning, and asserts that the stored `DATETIME` is the source instant in that zone, and in `Asia/Shanghai` for the control. 2. **Comments**: added to `timestampTzZoneWarningLogged` (set only once a warning has been logged, per writer instance, not kept in state) and to `collectTimestampTzPaths` (the path notation is for the message only). I also rebased onto `dev` to pick up #12938, which fixes the `LLMBooleanOutputTest` failure that stopped the earlier fork build before the connector modules ran. The Doris unit tests pass locally on JDK 11 (158). I haven't run the IT locally; fork CI run for this head: https://github.com/zhengxiang378928908-code/seatunnel/actions/runs/39779998506. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
