DanielLeens commented on PR #12930: URL: https://github.com/apache/seatunnel/pull/12930#issuecomment-6338262007
Thanks for the contribution. A CI-status correction on unchanged head `4aef355baf3530117c4c6ac8dba4539b98cd8aa5`: the [fork Build](https://github.com/nzw921rx/seatunnel/actions/runs/39634844106) has now completed with **failure**, so my earlier description of an in-progress run is obsolete. The relevant JDK 17 [`engine-resource-managers-it`](https://github.com/nzw921rx/seatunnel/actions/runs/39634844106/job/119358196918) still fails `KubernetesSessionIT.provisionsWorkerForPendingJobSlots`: its wait ends with a failed job carrying `NoEnoughResourceException` from `CoordinatorService.pendingJobSchedule`. JDK 11 passed; that does not cancel the JDK 17 regression signal. This is the same Issue 1 evidence in my previous full review, not a new source finding. Issues 1 and 2 (pending-capacity accounting/allocation wait and restoring the max-workers guard regression) remain blockers. Please fix those together and rerun the session IT; a generic base sync is not the demonstrated remedy. The four failed `unit-test` legs remain separate from that result. The inspected JDK 11 log fails `LLMBooleanOutputTest.readsLegacyFactoryWrapperWithValidationDisabled` with `InvalidClassException` on `AbstractMultiCatalogTransform`. The upstream fixture issue is now tracked by #12929 and proposed fix #12938, which is still open. Latest `dev` is still `99ea16b9d6bdce452d4c4955581ccc7236a81bbd`; syncing it today does not incorporate that fix. Once the correction lands in the base, sync and rerun the affected failed jobs. Please keep unrelated transform-serialization patches out of this PR. The base comparison is `diverged` against `dev` (ahead 26, behind 10); this drift is recorded separately. A successful required Build and final write-capable maintainer approval remain necessary. This comment updates CI facts only and is not a fresh full review or an approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
