jjj-n commented on PR #12925: URL: https://github.com/apache/seatunnel/pull/12925#issuecomment-6358396080
Thanks for the detailed review. I rebased the branch onto the latest `dev` and pushed `4b3d9de08cca80f7e0c631aa32ca72d02d38a6ea`. The two blocking findings are addressed: - Atomic staged publication is now limited to the `restoreJob` overloads. Normal `executeJob` paths keep the direct copy behavior and do not add an extra `docker exec`. A regression test verifies that direct copy performs zero container exec calls. - The real-container REST sampler now uses 5-second connect/read timeouts. The deliberately unresponsive local fixture keeps the 1-second timeout, and a 1.5-second slow healthy response regression was added. The connector target path is also normalized for `SEATUNNEL_HOME` values with a trailing slash. Local validation: - `./mvnw -q -DskipTests verify`: passed - `ContainerUtilTest`: 11 tests, 0 failures - `SavepointRestoreIT#testConnectorJarPublicationDuringRestore`: the savepoint/restore assertions passed in one Maven/Failsafe run and two direct JUnit repetitions; the final repetition also had clean teardown The new fork Build completed before the test matrix could start: - `Run / changes` failed because `ubuntu-latest` resolved to Ubuntu 26.04, where `actions/setup-python` could not find the workflow's exact Python `3.11.0`. - `Run / Code style` failed on the same Ubuntu 26.04 runner with Lombok/javac `TypeTag :: UNKNOWN`. - License header and dead-link checks passed; unit and integration-test jobs were skipped. The current upstream `dev` Build has the same two failures on the same runner image: https://github.com/apache/seatunnel/actions/runs/39817003666 I kept these unrelated workflow/environment fixes out of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
