DanielLeens commented on PR #12927: URL: https://github.com/apache/seatunnel/pull/12927#issuecomment-6377512383
Hi @SEPURI-SAI-KRISHNA, thank you for the thorough CI write-up and for the honest correction about `compatible_kafka_connect_json`. Covering issue 2 in #12953 and #12967 is exactly the right way to keep this PR to one problem. A status update, since my last review noted the apache-side `Build` as `IN_PROGRESS` for head `dcc48f42`: that note is now stale. The [Build](https://github.com/apache/seatunnel/runs/120580008642) on the same head (`dcc48f42629d`) now reads **SUCCESS**. The fork run `39815781771` is on attempt 2 and concluded `success`, so the `unit-test (11, windows-latest)` timeout you traced to the `5804` shutdown hang did clear on a plain job rerun, with no new push needed. That matches your reading that it is the known #12640-class hang and not something in this diff. On the `Kafka.md:625` point: your plan is fine with me. Keeping this PR free of the protobuf sentence and updating it in whichever of this PR or #12953/#12967 merges last is the least risky ordering. Please just make sure that follow-up edit does not get lost in the second merge. From my side there is nothing further to change in the code. The remaining gate is the repository's normal committer approval and merge-queue step, which is not something you need to act on. Thanks again for the careful work here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
