SEZ9 commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6379176711
Following up on my re-read at `e4fa7bf9b367` (previous review at `1553d812ce`). Confirmed from that pass: the POM fixes are in, `ADLSHadoopConf.setSchema` is gone, and the `authority_host` / `hadoop_adls_properties` option descriptions plus the validator comments now state that the denylist is not exhaustive and the map must come from trusted operators. That closes F8 for me. For the remaining earlier points I'd rather tie each one to a change than guess, so a one-line pointer (or "not applicable") per item would help: - **F1:** `ADLSHadoopConf` consuming the same trimmed values the validator checks, so whitespace from env-var substitution can't pass validation and then fail at runtime. - **F2:** the English sink doc calling out the hierarchical-namespace (HNS) requirement behind the exactly-once / atomic `tmp_path -> path` rename claim. - **F3:** the validation rules (account_name/container naming, auth mutual exclusion, blocked `hadoop_adls_properties` keys) documented, and template placeholders that pass them. - **F4:** the description update covers the docs side; I'd still like a scheme/host check on `authority_host`/`tenant_id` in code before the client secret is POSTed. If that's already in, please point me to it. - **F5:** en/zh option tables synced with each other and with the options the factories expose. - **F6:** the global `account_key` log-mask addition in `ConfigShadeUtils` mentioned in the docs and/or the PR description. - **F7:** English source doc showing `discovery_mode` defaulting to `ONCE` and `start_mode` to `EARLIEST`, matching the code and the Chinese doc. None of these are blockers on their own: F1 and F7 should be quick, F4 is the one I'd like resolved in code, and F6 is a user-visible global change worth calling out before merge. Thanks again for your patience across the rounds; once you've replied I'll do a final pass. <!-- streview-comment:1992 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
