SEZ9 commented on issue #12955: URL: https://github.com/apache/seatunnel/issues/12955#issuecomment-6380039304
Thanks for the clear report and root cause analysis. It matches the stack trace: for negative epoch microseconds, `micro / 1000` and `micro % 1000 * 1000` round toward zero, leaving a negative nanos remainder that `LocalTime.ofNanoOfDay` rejects, and the `NanoTimestamp` branch has the same split. Switching both branches to floor-based division/modulo should fix this without changing results for post-1970 values. Since you're willing to submit a PR, please go ahead. It would be great to include unit tests covering `1969-12-31 23:59:59.999999` for both the `MicroTimestamp` and `NanoTimestamp` paths. <!-- streview-comment:2004 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
