karthik-0306 commented on PR #12858: URL: https://github.com/apache/seatunnel/pull/12858#issuecomment-6381784510
Thanks @DanielLeens, and please don't apologize! Catching something subtle like this on a later pass is exactly why a fresh re-review is useful, and it's a real catch that I'd missed too. I took Option A in the latest commit: the `select_plugins()` docstring now notes that CRLF line endings are preserved, but `bin/install-plugin.sh` only accepts LF endings (a connector line ending in `\r` is rejected as an invalid artifact ID), so callers should pass a `plugin_config` with LF endings as shipped in the distribution. Docstring only, no behavior change; all 55 SDK tests still pass on Python 3.9, 3.11 and 3.13. On CI: I'll re-run only the failed Windows unit-test job if it is still red on the new head, without touching the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
