nzw921rx opened a new pull request, #12980:
URL: https://github.com/apache/seatunnel/pull/12980

   ### Purpose of this pull request
   
   Fix a callback-completion race in `TaskExecutionServiceTest.testFinish`, 
observed in [Windows / Java 17 
CI](https://github.com/apache/seatunnel/actions/runs/39915148118/job/120402965861).
   
   The original future may complete before its `whenComplete` callback sets the 
marker. Wait for the dependent future returned by `whenComplete` instead. Both 
assertions and the timeout remain unchanged. Only the existing test method 
changes; no production code, build configuration or CI gates change.
   
   ### Does this PR introduce any user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   - JDK 17 deterministic latch-based reproduction using SeaTunnel's unchanged 
CompletableFuture: reproduced the original race and verified waiting for the 
dependent future.
   - Focused `testFinish`: 1 test passed.
   - Full `TaskExecutionServiceTest`: 20 passed, no failures/errors/skips; 
cached ByteBuddy agent supplied at JVM startup because dynamic self-attach is 
unavailable locally.
   - Scoped Spotless passed.
   
   Validation limits: Java dependency build used the existing local 
`-Dskip.ui=true` option after the unrelated UI package CDN returned HTTP 403. 
Offline root verify stopped at uncached Flink 1.15.3 dependencies. Neither is a 
full-build pass; no repository settings or gates were changed. No new tests 
were added because this fixes the existing test's synchronization.
   
   ### Check list
   
   Not applicable: no new binaries, feature/docs, compatibility or connector 
changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to