davidzollo commented on PR #10698: URL: https://github.com/apache/seatunnel/pull/10698#issuecomment-6393946924
Addressed the Hive SQL-rewrite review findings in `232204de1f62` and synchronized with current `dev`. Metadata discovery now adds a top-level `LIMIT 1` without wrapping the query in a subquery, preserving projection and Hive column qualification. The scan respects quoted literals/identifiers, block and CR/LF line comments, CTE syntax and trailing terminators; existing top-level limits, multiple statements, incomplete syntax and CTE-prefixed data-changing statements remain unchanged. Twenty exact-output cases replace the reflection-only tests. The existing real Hive integration test now compares column names, labels and JDBC types with the original SQL for ordinary queries, comments, CTEs and existing limits. English and Chinese JDBC documentation describe the metadata-only scope and query-plan limits. A statement `setMaxRows` change alone was avoided because Hive applies that limit in the client result set, rather than rewriting server execution. Affected JDBC and Hive-IT modules passed Spotless and static diff checks; the final patch received independent internal review. Fresh current-head GitHub CI remains required for runtime validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
