DanielLeens commented on PR #12726: URL: https://github.com/apache/seatunnel/pull/12726#issuecomment-6396682705
Thanks for your patience with the shared CI failure. I need to update my earlier upstream guidance: the JDBC fixture correction is now in `dev`, via [#12938](https://github.com/apache/seatunnel/pull/12938), commit [`cc54bb43335`](https://github.com/apache/seatunnel/commit/cc54bb433357b4cb45db9cd5d0743589c3111b79). Proposed #12875 was closed without merging; it is not the commit to wait for. I read the current failing [unit-test job](https://github.com/xinnyuli/seatunnel/actions/runs/39204677425/job/117905628154): `JdbcOptionRuleCompletenessTest.testSinkRuleDeclaresAllSinkOptions` rejects `numeric_special_value_as_null`. The merged correction excludes that source-only option from the sink completeness fixture and adds an explicit source/sink contract check. I confirmed the correction in latest `dev` source; this PR's current diff does not change that fixture. The head remains `dc6975b7022c60d327fce5ff945e05fdb31f4faa`. The checked comparison against `dev` is `diverged`, ahead 2 / behind 45. Please sync with the latest `dev` and rerun the affected unit-test jobs for the resulting head. Keep unrelated JDBC-fixture patches out of this PR. This is a targeted remedy for the demonstrated upstream failure, not a guarantee that every other job will pass. Other currently unsuccessful jobs remain separate: `all-connectors-it-2 (11, ubuntu-latest)`, `all-connectors-it-2 (17, ubuntu-latest)`, `all-connectors-it-6 (11, ubuntu-latest)`, `all-connectors-it-6 (17, ubuntu-latest)`, `engine-v2-it (17, ubuntu-latest)`, `hbase-connector-it (11, ubuntu-latest)`, `hbase-connector-it (17, ubuntu-latest)`, `mysql-cdc-connector-it (11, ubuntu-latest)`, `mysql-cdc-connector-it (17, ubuntu-latest)`, `transform-v2-it-part-2 (11, ubuntu-latest)`, `transform-v2-it-part-2 (17, ubuntu-latest)`. Their causes are not established by this fixture fix. GitHub also reports an independent merge conflict. Please resolve it while syncing, preserving both intended changes; a green CI result alone cannot clear that gate. My previous source-level conclusion is unchanged. This is an upstream/CI fact update, not a fresh full code review or an approval. A successful final-head Build and the repository’s write-capable maintainer approval remain necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
