DanielLeens commented on PR #12578: URL: https://github.com/apache/seatunnel/pull/12578#issuecomment-6397051776
Thanks @hutiefang76 and @SEZ9. I re-checked the points against the unchanged head `ef53a70c6` (code reading only, nothing executed locally): - `SeaTunnelRow.setField` assigns the field and only writes `size = 0` under `if (size != 0)`, so the unconditional volatile write on the construction path is gone (F1), and its Javadoc states the `getFields()` and nested-mutation limitation (F2). - `SeaTunnelRowTest` now has `testSetFieldInvalidatesCachedBytesSize`, `testDirectFieldMutationDoesNotInvalidateCachedBytesSize` and `testNestedFieldMutationDoesNotInvalidateParentCachedBytesSize`, which cover the cross-overload case and pin the documented limitation (F3/F4/F5). So the earlier source and test follow-ups are all in place; I have no open source-side blocker. The one remaining gap is the PR-bound check: the apache-side `Notify test workflow` is still `failure` on this head, and the fork run being green does not replace it. Since that check is not triggered by a code change, a maintainer needs to retry just that failed workflow; I do not have permission to do so. @SEZ9 or @davidzollo, could you please re-run it when convenient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
