DanielLeens commented on PR #11564: URL: https://github.com/apache/seatunnel/pull/11564#issuecomment-6396815799
Thanks for consolidating this, @SEZ9. These overlap the executor/backlog, asynchronous response/error contract and test-seam concerns already discussed here, so I agree with keeping one existing list rather than creating duplicate findings. Please address the bounded engine-owned executor and accurate `Offload` Javadoc first, while preserving response-failure visibility and Hazelcast's handling of fatal errors. The test should use an injectable executor seam instead of reaching into a private Hazelcast field. No new commit is present yet, so I cannot mark these code-side concerns cleared or treat a CI rerun as a substitute for the fix. I will wait for the updated implementation and review the complete diff on that head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
