JeremyXin commented on PR #11841: URL: https://github.com/apache/seatunnel/pull/11841#issuecomment-6399478230
@SEZ9 Thanks for re-checking and for withdrawing the compatibility and submitJob concerns. You are right that JobMaster.init calls handleSaveMode only for non-restore jobs. I intend to keep that guard because changing it would alter the existing cluster-side save-mode behavior. The restore branch remains in the public helper to preserve the behavior of callers of the deprecated boolean overload, including true. For CheckpointCoordinator, the value flows through JobMaster.initCheckPointManager → CheckpointManager → its CheckpointCoordinator constructor. JobMaster already passes jobImmutableInformation.isRestoreJob() || restart, so this PR corrects the parameter name without changing the value passed. @DanielLeens Confirmed at 881e275f: JobMaster.init is the only direct in-repo production call site of handleSaveMode(..., RestoreMode). The other in-repo uses are its multi-table recursion and the deprecated boolean overload delegating to it. I’ll describe the restore branch as preserved public-helper behavior, rather than suggesting the guarded init path reaches it. Thanks for tracing the checkpoint-manager call chain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
