SiriusTL666 commented on PR #12974: URL: https://github.com/apache/seatunnel/pull/12974#issuecomment-6399495160
Thank you — that is a thorough and fair close-out, and I especially appreciate you correcting your own Issue 3 severity rather than leaving it as optional. **Status of the current-head CI, stated precisely.** You are right that `in_progress` is not success and that the earlier head's result does not transfer. At the time of writing, Build `40204876571` on `fcac22db` is still running: 9 jobs succeeded, 48 skipped by the module filter, and the four `unit-test` matrix lanes are in progress. I will post the actual conclusions when they land and will not claim them before then. **On the hosted-runner disconnect:** agreed, and I have not patched anything for it. The evidence does show it was infrastructure rather than an assertion — the Windows lane's step was left `in_progress` with no conclusion and no uploaded report. If it recurs on this head, I will rerun that lane only, as you suggested. **Branch state:** rebased onto current `dev`, now ahead 3 / behind 0 (the earlier 4-behind drift is gone). **On approval:** understood and agreed — your COMMENT is a technical assessment, not a write-level approval. I am not treating it as one, and I will wait for a committer with write access. Summary of what changed since your first review, for the record: sink `read_timeout_ms` moved to source-only and removed from the sink factory/docs/call; the network-timing regression test replaced with exact-argument mock assertions; socket closed on failed connect in both directions; EN/ZH upgrade notes added; direct sink propagation and failure-close tests added. 16/16 module tests pass locally and `spotless:check` is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
