DanielLeens commented on PR #12978: URL: https://github.com/apache/seatunnel/pull/12978#issuecomment-6397813541
Thanks for the contribution. The CI/merge fact in my previous review has changed. The exact-head [fork Build](https://github.com/goutamadwant/seatunnel/actions/runs/40110088838) is now **completed with failure** for `eb56896d57e4b2cfc9144b3e5d0d74312cdfda53`. This is a gate correction, not a second full source review of that unchanged head. The Windows unit-test jobs failed on JDK 11 and 17. In the inspected [JDK 17 job](https://github.com/goutamadwant/seatunnel/actions/runs/40110088838/job/121069663672), 13 `ParquetReadStrategyTest` errors report `HADOOP_HOME and hadoop.home.dir are unset`. The new `ExampleParquetWriter` fixture creation (`ParquetReadStrategyTest.java:168,422`) reaches Hadoop's local permission/native-helper setup before the projection assertions execute. This is a test-fixture portability failure associated with this PR, not evidence that the projection values are wrong. Latest dev has no corresponding fix for these new fixtures. Please make the fixture setup portable on the supported Windows lanes, or supply the existing test harness's correctly configured Hadoop prerequisites, then rerun both Windows UT legs. Keep both reader paths and the projection/value assertions; simply skipping those tests would remove the intended regression proof. No unrelated connector dependency change or generic dev sync is justified by this signature. Comparison against dev is `diverged`, ahead 1 / behind 8; merge conflicts: no. Drift is recorded independently and does not itself justify a sync request. No new source-level blocker from my previous full review is asserted here; a successful required Build and write-capable maintainer approval remain separate gates. Daniel has READ permission, so this comment is not an effective approval. Thanks for keeping the fix focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
