SEZ9 commented on PR #11479: URL: https://github.com/apache/seatunnel/pull/11479#issuecomment-6408422842
Thanks for the follow-up revision at `31ce4465a3280d184114575884ba4b7a406d6d7c`. I re-read the full target-relative diff, and the earlier short-handle, overwrite and documentation blockers are addressed: integer handle decoding is now gated on `isPkHandle`, so a DECIMAL(9,0) key reaches the snapshot/PUT/DELETE restore path, and restore now fills only null primary-key slots. One remaining item: the newly added key-only DELETE fallback allocates an all-null image and decodes every PK component from the record key. For a collation-sensitive string PK column there is no original string to preserve, so the key-decoded bytes may not match the stored value. Please add a guard for this case (for example, skip or log when a string PK column under a sensitive collation would be filled from the key only) so the fallback does not emit a silently wrong identity. Once that guard is in, I'm happy to take another pass. <!-- streview-comment:2053 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
